Convert code base to ESM import #3778
Conversation
|
package.json
Outdated
| @@ -10,6 +10,7 @@ | |||
| "babel-plugin-transform-es2015-destructuring": "^6.23.0", | |||
| "babel-plugin-transform-es2015-parameters": "^6.23.0", | |||
| "babel-plugin-transform-flow-strip-types": "^6.18.0", | |||
| "babel-plugin-transform-inline-imports-commonjs": "^1.2.0", | |||
| "babel-plugin-transform-runtime": "^6.23.0", | |||
There was a problem hiding this comment.
should this be in this PR? I mean babel-plugin-transform-inline-imports-commonjs
There was a problem hiding this comment.
Oh sorry, good catch. Wrong plugin!
|
Bah, didn't change .babelrc. Only one failure! |
|
👌 |
| @@ -5,7 +5,8 @@ | |||
| "transform-es2015-destructuring", | |||
| "transform-es2015-parameters", | |||
| "transform-async-to-generator", | |||
| "transform-strict-mode" | |||
| "transform-strict-mode", | |||
| ["transform-es2015-modules-commonjs", {"allowTopLevelThis": true}] | |||
There was a problem hiding this comment.
I added the allowTopLevelThis option, otherwise this throws. Might not be an issue, not sure?
|
I apparently hit a bug in node 6.10.1. Upgrading to 6.11.0 and all tests pass. Pushed an empty commit to trigger CI. |
Generated by 🚫 dangerJS |
Codecov Report
@@ Coverage Diff @@
## master #3778 +/- ##
==========================================
- Coverage 59.82% 58.09% -1.73%
==========================================
Files 191 191
Lines 7016 6708 -308
Branches 6 6
==========================================
- Hits 4197 3897 -300
+ Misses 2816 2808 -8
Partials 3 3
Continue to review full report at Codecov.
|
* Convert code base to ESM import * [squash] specify correct babel plugin for import transpilation * [squash] specify correct babel plugin for import transpilation in babelrc * trigger ci
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Summary
This is just the
require-> ESM parts of #3493. Split off in order to land it and make it easier to diagnose the test failures. The same 2 tests fail as with the other PR. Halp.Test plan
Tests should pass.